Quantus icon indicating copy to clipboard operation
Quantus copied to clipboard

Mypy: fix errors

Open dilyabareeva opened this issue 3 years ago • 2 comments

Implemented changes

  • fix most errors @annahedstroem Please check the remaining errors.
  • small edits in CONTRIBUTING.MD
  • branched from mypy-static-type-checker

dilyabareeva avatar Oct 12 '22 22:10 dilyabareeva

Codecov Report

Merging #171 (eb07d66) into main (b77d586) will decrease coverage by 0.12%. The diff coverage is 80.85%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   92.86%   92.74%   -0.13%     
==========================================
  Files          54       54              
  Lines        2649     2660      +11     
==========================================
+ Hits         2460     2467       +7     
- Misses        189      193       +4     
Impacted Files Coverage Δ
quantus/functions/explanation_func.py 89.07% <ø> (ø)
quantus/helpers/model/tf_model.py 94.11% <0.00%> (ø)
quantus/metrics/axiomatic/completeness.py 94.28% <ø> (ø)
quantus/metrics/axiomatic/input_invariance.py 100.00% <ø> (ø)
quantus/metrics/axiomatic/non_sensitivity.py 100.00% <ø> (ø)
quantus/metrics/complexity/complexity.py 100.00% <ø> (ø)
quantus/metrics/complexity/effective_complexity.py 100.00% <ø> (ø)
quantus/metrics/complexity/sparseness.py 100.00% <ø> (ø)
...s/metrics/faithfulness/faithfulness_correlation.py 95.83% <ø> (ø)
...ntus/metrics/faithfulness/faithfulness_estimate.py 97.95% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 12 '22 22:10 codecov-commenter

Remaining is to resolve merge conflicts as seen ^^. (@dkrako has cleaned up the custom_preprocess so most of the metric files are affected)

annahedstroem avatar Oct 13 '22 06:10 annahedstroem

Checked the remaining errors which are fixed or rejected (as non-important error or error is wrong).

annahedstroem avatar Oct 20 '22 18:10 annahedstroem