extra.css icon indicating copy to clipboard operation
extra.css copied to clipboard

Custom properties naming

Open vitaliy-bobrov opened this issue 6 years ago • 2 comments

Now custom properties names look like this - --extra-confettiLengthVariance, which is a mix of 2 styles - camelCase and CSS one, IMHO it might be better to use names more common for CSS, ex. --extra-confetti-length-variance instead

vitaliy-bobrov avatar Aug 16 '19 12:08 vitaliy-bobrov

I agree with @vitaliy-bobrov

The Material Design Theming Guide has custom properties with naming --mdc-theme-primary, can you see Step 4: Changing the theme with CSS Custom Properties at https://material.io/develop/web/docs/theming/

And the same CSS custom properties naming in Firefox 👉🏼 https://github.com/mozilla/gecko-dev/blob/4ff64f4001ea521adba31bbe8fd5fa547c99e0b2/browser/themes/osx/browser.css

nucliweb avatar Aug 16 '19 21:08 nucliweb

I can help with the refactor too 😊

nucliweb avatar Aug 16 '19 21:08 nucliweb