umee icon indicating copy to clipboard operation
umee copied to clipboard

Consider using goimports to keep our imports well formed

Open brianosaurus opened this issue 3 years ago • 1 comments

Summary

goimports is a tool that will keep our imports clean. We could use it to automatically add or remove imports where needed.

Problem Definition

This is a tool to keep imports consistent. Some of our imports are not in order at the moment. This tool would fix these items.

https://pkg.go.dev/golang.org/x/tools/cmd/goimports

Proposal

Add goimports to our Makefile so that it is run when we perform a build of our daemon. See the Axelar Makefile for an example:

https://github.com/axelarnetwork/axelar-core/blob/main/Makefile#L41


For Admin Use

  • [ ] Not duplicate issue
  • [ ] Appropriate labels applied
  • [ ] Appropriate contributors tagged
  • [ ] Contributor assigned/self-assigned

brianosaurus avatar May 25 '22 21:05 brianosaurus

goimports is part of https://github.com/golangci/golangci-lint - so we should just update the config.

robert-zaremba avatar May 26 '22 19:05 robert-zaremba