ultraleap
Fix incorrect joint confidence colouring
Change the target colour palette values for joint confidence targets in the render texture as they appear altered from the expected values
Summary
When investigating the Lumi work, it appeared that the joint values calculated in the render texture, which are used as the target pixel colours for counting / calculating joint visibility do not match the source values used to render the capsule hands. This is unexpected but several days of looking for potential causes failed to determine the issue. This code contains new target values, based on the pixel colours in the rendertexture and also some code that can be used to log out the colours, which is useful in checking if this is an issue that occurs across multiple systems/versions/platforms.
Contributor Tasks
- [ ] Create or edit test cases here
- [ ] Add a CHANGELOG entry for this change.
- [ ] Ensure documentation requirements are met e.g., public API is commented.
- [ ] Consider any licensing/other legal implications for this MR e.g. notices required by any new libraries.
Test Cycle
Link to the test cycle here.
Reviewer Tasks
- [ ] Code reviewed.
- [ ] Non-code assets e.g. Unity assets/scenes reviewed.
- [ ] All tests must be ran and cover all scenarios (If not, add new tests to the cycle and run them).
- [ ] Documentation has been reviewed.
- [ ] Approve with a comment of any additional tests run or any observations.
Related JIRA Issues
If this MR closes any JIRA issues list them below in the form Closes PROJECT-#
Pull Request Templates
Switch template by going to preview and clicking the link - note it will not work if you've made any changes to the description.
- default.md - for contributions to stable packages.
- release.md - for release merge requests.
You are currently using: default.md
Note: these links work by overwriting query parameters of the current url. If the current url contains any you may want to amend the url with &template=name.md instead of using the link. See query parameter docs for more information.
Are we expecting to merge this/improve on this further, or is this dead now?
Converting this PR back to a draft as it needs further work or closing.