Decode null string thows NullReferenceException

Open ellull opened this issue 2 years ago • 1 comments

We were using the 1.4.1 version of this library and decoding a null string returned an empty array. But after upgrading to the 1.7.0 version it throws a NullReferenceException.

With git bisect I found that the bug was introduced in the commit 480cabe42bf1d3f072370d87aa77f65d2f9dbae9.

The bug is in the long[] Hashids.GetNumbersFrom(string hash) method. If hash is null, the variable result will be an empty array, which is expected but in the next line of GetNumbersFrom it uses the Length property of hash, which is null and the NullReferenceException is thrown.

After creating the issue I'll create a PR with the unit tests and the fix.

Oct 25 '23 08:10 ellull

Nice, thank you @ellull I'll look at your PR and see if I can get a new version out shortly.

Oct 26 '23 18:10 ullmark