ruby-gpgme icon indicating copy to clipboard operation
ruby-gpgme copied to clipboard

gpgme_ctx_set_engine_info added as a new interface

Open keitaroemotion opened this issue 8 years ago β€’ 6 comments

Currently, ruby-gpgme's set_info contaminates the global gpg status. For example, if there are several gpg process running simultaneously, one gpg fails since the other deprives of the working repository.

Then I added a new interface called set_info_safe, which take context as an argument so that it does not harm the other gpg related processes.

keitaroemotion avatar Nov 24 '17 01:11 keitaroemotion

Coverage Status

Coverage decreased (-0.2%) to 90.261% when pulling ef9f1d7d1330fee711c6f859ad319c008715ceb2 on keitaroemotion:add-non-intrusive-set-info into f70d0268edbc361ac8e21968252fdf64f5f7feac on ueno:master.

coveralls avatar Nov 24 '17 01:11 coveralls

Why don't you put that method to GPGME::Ctx class?

However, I'm surprised that gpgme_set_engine_info is already exposed.

iwat avatar Nov 24 '17 02:11 iwat

@chaiwat You're right. now it has been moved into Ctx na. Yes.... so maybe initially people tried to implemented it but turned out to be it was forgotten to implement... I assume....

keitaroemotion avatar Nov 24 '17 06:11 keitaroemotion

Coverage Status

Coverage decreased (-0.2%) to 90.261% when pulling be9e87b92e69b425a5ea405a70d9f616c3e29ec1 on keitaroemotion:add-non-intrusive-set-info into f70d0268edbc361ac8e21968252fdf64f5f7feac on ueno:master.

coveralls avatar Nov 24 '17 07:11 coveralls

@ueno Please merge this branch πŸ™‡ γŠι‘˜γ„γ—γΎγ™

keitaroemotion avatar Nov 24 '17 07:11 keitaroemotion