plate icon indicating copy to clipboard operation
plate copied to clipboard

Fix combobox opening popover for all users in collaboration

Open felixfeng33 opened this issue 2 months ago • 4 comments

Checklist

  • [x] yarn typecheck
  • [x] yarn lint:fix
  • [x] yarn test
  • [x] yarn brl
  • [x] yarn changeset
  • [x] ui changelog

felixfeng33 avatar Nov 30 '25 09:11 felixfeng33

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Nov 30 '25 09:11 codesandbox[bot]

🦋 Changeset detected

Latest commit: 413fa9d49e55d59a8acb40c275aaa7a06896cf08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@platejs/combobox Patch
@platejs/yjs Patch
@platejs/emoji Patch
@platejs/mention Patch
@platejs/slash-command Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 30 '25 09:11 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
plate Ready Ready Preview Comment Nov 30, 2025 10:05am

vercel[bot] avatar Nov 30 '25 09:11 vercel[bot]

Claude finished @felixfeng33's task —— View job


Changeset Review Complete ✅

I've reviewed the changesets and updated the changelog for this PR.

Changes Made:

  • Verified existing changesets - Both changesets (lemon-numbers-look.md and yjs-user-id.md) follow all guidelines correctly
  • Updated changelog - Added entry for inline-combobox Yjs collaboration support in docs/components/changelog.mdx

Existing Changesets Summary:

  1. @platejs/combobox (patch): Adds getUserId option to fix popover opening for all users
  2. @platejs/yjs (patch): Adds userId option for collaboration support

The changesets properly document the fix for combobox popovers opening for all users in collaborative editing. Now, only the user who triggers the combobox will see the popover.


claude[bot] avatar Nov 30 '25 09:11 claude[bot]