plate icon indicating copy to clipboard operation
plate copied to clipboard

Custom onRenderContainer prop passed to <table>

Open Dem0n3D opened this issue 4 years ago • 0 comments

Description I'm using my own table popover with tool buttons like this:

export const TablePopover = ({
  element,
  popoverProps,
  children,
}) => (
  <Popover content={
    <>
      <TableToolbarButton icon={<ToolbarIcon className="mdi-table-column-remove" />} transform={deleteTable} />
      <TableToolbarButton icon={<ToolbarIcon className="mdi-table-row-plus-after" />} transform={addRow} />
      <TableToolbarButton icon={<ToolbarIcon className="mdi-table-row-remove" />} transform={deleteRow} />
      <TableToolbarButton icon={<ToolbarIcon className="mdi-table-column-plus-after" />} transform={addColumn} />
      <TableToolbarButton icon={<ToolbarIcon className="mdi-table-column-remove" />} transform={deleteColumn} />
      <RemoveNodeButton element={element} />
    </>
  } {...popoverProps}>
    {children}
  </Popover>
);


export const TableElement2 = props => <TableElement {...props} onRenderContainer={TablePopover}/>

Popover is working, but I get warning: Warning: Unknown event handler property onRenderContainer. It will be ignored.

I think, onRenderContainer passes through const rootProps = getRootProps(props);.

Steps

  1. Define popover with code above
  2. Install it by adding [ELEMENT_TABLE]: TableElement2 in createPlateUI.

Expectation

onRenderContainer shouldn't be passed to <table> props.

Environment

  • plate: 9.2.1
  • slate: 0.72.3
  • slate-react: 0.72.1
  • browser: chrome 97

Dem0n3D avatar Jan 27 '22 19:01 Dem0n3D