chipyard icon indicating copy to clipboard operation
chipyard copied to clipboard

Bump conda-lockfiles for latest version of conda/conda-lock

Open joonho3020 opened this issue 2 years ago • 2 comments

Latest version of conda doesn't support conda-lock=1.4.

Related PRs / Issues:

Type of change:

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Other enhancement

Impact:

  • [ ] RTL change
  • [ ] Software change (RISC-V software)
  • [ ] Build system change
  • [ ] Other

Contributor Checklist:

  • [ ] Did you set main as the base branch?
  • [ ] Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • [ ] Did you state the type-of-change/impact?
  • [ ] Did you delete any extraneous prints/debugging code?
  • [ ] Did you mark the PR with a changelog: label?
  • [ ] (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • [ ] (If applicable) Did you add documentation for the feature?
  • [ ] (If applicable) Did you add a test demonstrating the PR?
  • [ ] (If applicable) Did you mark the PR as Please Backport?

joonho3020 avatar Mar 14 '24 04:03 joonho3020

Let's bump conda-lock to a modern version (v2+). And also update the setup docs. But I'm not sure if the new lockfiles can be read by conda-lock v1 - we should check that too; otherwise this is a breaking change

vighneshiyer avatar Mar 14 '24 17:03 vighneshiyer

Let's bump conda-lock to a modern version (v2+). And also update the setup docs. But I'm not sure if the new lockfiles can be read by conda-lock v1 - we should check that too; otherwise this is a breaking change

+1 on this. We should try to bump to the latest version of conda-lock but still "pin" it in the setup docs and in the reqs.yaml files. We should also make sure to update FireSim as well (since the lockfile + docs there is still using 1.4).

Also to ease the breaking change it might make sense to add a check before the conda-lock invocation to ensure that it is up-to-date (kinda how we do the same with Make).

abejgonzalez avatar Mar 14 '24 17:03 abejgonzalez

Unneeded since https://github.com/ucb-bar/chipyard/pull/1957 sets up conda-lock properly for all users.

abejgonzalez avatar Aug 28 '24 00:08 abejgonzalez