Sharpmake icon indicating copy to clipboard operation
Sharpmake copied to clipboard

Fix: DLL dependencies not copied to target folder

Open firesgc opened this issue 6 months ago • 4 comments

My DLL project depends on another project that copies DLLs to the target folder. For example:

conf.TargetCopyFilesToSubDirectory.Add(new KeyValuePair<string, string>(@"[project.SharpmakeCsPath]/bin/x64/D3D12Core.*", "D3D12"));)

Currently, the copy dependencies of DLL projects are ignored. This change fixes that issue so that dependent DLLs are correctly copied to the target folder.

firesgc avatar Oct 24 '25 07:10 firesgc

Could you modify one of the samples to use this case ?

jspelletier avatar Oct 24 '25 13:10 jspelletier

Does Vcxproj.cs in its GenerateFilesSection function need a similar change for generator consistency?

martinecker-ATVI avatar Oct 24 '25 14:10 martinecker-ATVI

Does Vcxproj.cs in its GenerateFilesSection function need a similar change for generator consistency?

ideally as well yes if this applies. In general we try to have the same behavior for msbuild + fastbuild.

jspelletier avatar Oct 24 '25 15:10 jspelletier

Does Vcxproj.cs in its GenerateFilesSection function need a similar change for generator consistency?

ideally as well yes if this applies. In general we try to have the same behavior for msbuild + fastbuild.

I’ve added the fix to msbuild too. I’ll see later if I find an example to copy or improve on, but I’m not sure when I’ll have time.

firesgc avatar Oct 24 '25 20:10 firesgc