rides-java-sdk icon indicating copy to clipboard operation
rides-java-sdk copied to clipboard
verified publisher icon uber

Allow to wiremock API responses instead of using sandbox

Open pjagielski opened this issue 9 years ago • 6 comments

Motivation

We extensively use Rides API and have about 30 integration tests with various API interactions. When using sandbox our build took about 8 minutes to finish, so we decided to mock Rides API with WireMock. Now the build takes less than 3 minutes ;)

Details

Instead of setting Environment we added a baseUrl property which is used to build endpointHost if present.

pjagielski avatar Nov 18 '16 16:11 pjagielski

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 18 '16 16:11 CLAassistant

Thanks for the commits! I won't have time to full review until after Thanksgiving week, but then this will be on my radar to get reviewed and merged.

tyvsmith avatar Nov 18 '16 22:11 tyvsmith

Sorry about this, busy week has lead to still not getting to this, we'll look to get at this soon.

itstexter avatar Dec 03 '16 01:12 itstexter

+1

rompic avatar Apr 22 '17 06:04 rompic

Getting back to this after a while away from this project. Change looks good but needs to be rebased.

tyvsmith avatar Aug 16 '18 23:08 tyvsmith

Rebased ;)

pjagielski avatar Sep 03 '18 07:09 pjagielski