okbuck icon indicating copy to clipboard operation
okbuck copied to clipboard

Cleanup proguard in generated dependencies

Open kurtisnelson opened this issue 5 years ago • 2 comments

In buck, the proguard-gradle dependency is unused. Additionally, OkBuck internally pins to a version of proguard instead of allowing the consumer to specify it.

kurtisnelson avatar Aug 05 '20 01:08 kurtisnelson

@kurtisnelson could you give an example?

Do you mean the proguard-gradle dependency generated in .buckconfig is not used?

Also proguard artifact version is looked up in the classpath https://github.com/uber/okbuck/blob/master/buildSrc/src/main/java/com/uber/okbuck/core/util/ProguardUtil.java#L24

Do we want the ability to specify a specific proguard version instead of auto lookup from the classpath?

raviagarwal7 avatar Aug 05 '20 10:08 raviagarwal7

I think the issue is two fold.

  • We don't need the proguard-gradle artifact
  • we can allow an override of the proguard jar target and set the default like we do today

kageiit avatar Aug 05 '20 13:08 kageiit