okbuck
okbuck copied to clipboard
Cleanup proguard in generated dependencies
In buck, the proguard-gradle dependency is unused. Additionally, OkBuck internally pins to a version of proguard instead of allowing the consumer to specify it.
@kurtisnelson could you give an example?
Do you mean the proguard-gradle dependency generated in .buckconfig is not used?
Also proguard artifact version is looked up in the classpath https://github.com/uber/okbuck/blob/master/buildSrc/src/main/java/com/uber/okbuck/core/util/ProguardUtil.java#L24
Do we want the ability to specify a specific proguard version instead of auto lookup from the classpath?
I think the issue is two fold.
- We don't need the proguard-gradle artifact
- we can allow an override of the proguard jar target and set the default like we do today