multidimensional_urlencode icon indicating copy to clipboard operation
multidimensional_urlencode copied to clipboard

Option to leave off empty array braces.

Open chr15m opened this issue 7 years ago • 7 comments

The combination of querystring_parser and Django will not correctly parse the params generated by this library unless you leave off the empty braces []. This patch adds an option to do so.

chr15m avatar Jun 25 '18 09:06 chr15m

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 25 '18 09:06 CLAassistant

Would love to see this merged. @chr15m any chance you can fix failing CI and maybe someone from Uber will look into this?

davidnemec avatar May 09 '19 09:05 davidnemec

@davidnemec I have fixed the tests.

chr15m avatar May 16 '19 04:05 chr15m

Good job @chr15m! I think there is also a need to sign Contributor License Agreement for CI to pass. Would you mind signing it please?

tomasbedrich avatar Jul 02 '19 13:07 tomasbedrich

@tomasbedrich I will not sign this CLA. You're welcome to the code of course!

chr15m avatar Jul 03 '19 01:07 chr15m

May I ask you, what is the reason not to sign it? I am not working at Uber so my motivation is not to push you into something you don't like. It would be just great to see your code merged for me to use it in my project. Of course, I respect you right to decline the CLA but it would be a pitty if your work remains unmerged (or someone else would need to duplicate it) just because of CLA.

tomasbedrich avatar Jul 04 '19 07:07 tomasbedrich

I do not have the time to determine the legal implications of signing the document.

It is possible to add git based dependencies to your requirements file and you could use this fork which includes the PRs: [email protected]:CultureCounts/multidimensional_urlencode.git.

Best of luck.

chr15m avatar Jul 04 '19 08:07 chr15m