h3 icon indicating copy to clipboard operation
h3 copied to clipboard

Clang warning in vertex.c

Open isaacbrodsky opened this issue 3 years ago • 1 comments

Clang 11.0.0:

/tmp/h3/src/h3lib/lib/vertex.c: In function ‘vertexRotations’:
/tmp/h3/src/h3lib/lib/vertex.c:88:47: warning: ‘dirFaces.faces[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   88 |         if (cellLeadingDigit == JK_AXES_DIGIT &&
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
   89 |             fijk.face ==
      |             ~~~~~~~~~~~~                       
   90 |                 dirFaces.faces[IK_AXES_DIGIT - DIRECTION_INDEX_OFFSET]) {
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/h3/src/h3lib/lib/vertex.c:93:54: warning: ‘dirFaces.faces[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   93 |         } else if (cellLeadingDigit == IK_AXES_DIGIT &&
      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
   94 |                    fijk.face ==
      |                    ~~~~~~~~~~~~                       
   95 |                        dirFaces.faces[JK_AXES_DIGIT - DIRECTION_INDEX_OFFSET]) {
      |                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

isaacbrodsky avatar Feb 21 '22 21:02 isaacbrodsky

I'm having similar issue: ...../vertex.c(85,47): warning GF881FBBE: ‘dirFaces.faces[3]’ may be used uninitialized in this function [-Wmaybe-uninitialized] [/__w/1/s/Src/Linux/Cmake.Build/Cmake.Build.csproj] ...../vertex.c(90,54): warning G214ECD21: ‘dirFaces.faces[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized] [/__w/1/s/Src/Linux/Cmake.Build/Cmake.Build.csproj]

michaelbrichko avatar Nov 13 '23 11:11 michaelbrichko