causalml icon indicating copy to clipboard operation
causalml copied to clipboard

CausalTreeRegressor with the paramters 'criterion=causal_mse' can't been traind when dataset is much larger than example's

Open lmaors opened this issue 3 years ago • 2 comments

Describe the bug CausalTreeRegressor with the paramters 'criterion=causal_mse' can't been trained when dataset is much larger than example's synthetic_data (e.g. X.shape[0] > 1000000). But CausalTreeRegressor with the paramters 'criterion=standard_mse' works.

Environment (please complete the following information):

  • OS: Ubuntu
  • Python Version: 3.7
  • pandas==1.3.5, scikit-learn==1.0.2, cython==0.29.30,numpy==1.21.6

Additional context causalml package was compiled from lastest source code

lmaors avatar Aug 28 '22 06:08 lmaors

When you say it can't be trained, what exactly happens when you try to do it?

t-tte avatar Oct 03 '22 23:10 t-tte

When the rows of datasets are much more than 1 million, It would spent much time to train.

lmaors avatar Oct 07 '22 12:10 lmaors

@lmaors, could you try the latest version from the repository? @alexander-pv further improved CausalTreeRegressor in #557.

Note that CausalTreeRegressor uses scikit-learn's tree implementation in Cython, and it's expected to be slower than XGBoost or LightGBM that are implemented in C++.

jeongyoonlee avatar Oct 21 '22 17:10 jeongyoonlee

@jeongyoonlee, it works, thanks.

lmaors avatar Oct 27 '22 03:10 lmaors