baseweb icon indicating copy to clipboard operation
baseweb copied to clipboard

fix(datepicker): prevent early parsing of enclosing date in range setup

Open atroncy opened this issue 3 years ago • 7 comments

Fixes #4891

Description

There is an hack used on the user input date when typing the days part of the date. This hack was not replicated in the case of the user choosing the range options. We applied this hack to the endDate of the range option (the hacks seems unecessary for the startDate somehow)

I'm not familiar on where/how I should implement test for this. Any guidance, appreciated.

Scope

Patch: Bug Fix

atroncy avatar Apr 08 '22 04:04 atroncy

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 08 '22 04:04 CLAassistant

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 389cbee5d104b3592b20b076baa171ae009a1bd0:

Sandbox Source
Basic usage Configuration

codesandbox-ci[bot] avatar Apr 08 '22 04:04 codesandbox-ci[bot]

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/atroncy/baseweb/pull/1

UberOpenSourceBot avatar Apr 12 '22 18:04 UberOpenSourceBot

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/atroncy/baseweb/pull/1

UberOpenSourceBot avatar Apr 14 '22 20:04 UberOpenSourceBot

This change is causing flow and unit test failures. Can you run the tests locally and to determine the issue?

lhbrennan avatar Apr 14 '22 20:04 lhbrennan

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/atroncy/baseweb/pull/1

UberOpenSourceBot avatar Apr 14 '22 21:04 UberOpenSourceBot

Visual changes have been resolved. https://github.com/atroncy/baseweb/pull/1 has been closed. If future commits on atroncy:master trigger visual changes, a new snapshot branch will be created and a new PR will be opened.

UberOpenSourceBot avatar Apr 20 '22 20:04 UberOpenSourceBot

Closing this in-progress pr to clean up the list. Please let us know if this is still an issue

chasestarr avatar Oct 04 '22 17:10 chasestarr