baseweb icon indicating copy to clipboard operation
baseweb copied to clipboard

Follow rules-of-hooks lint rule

Open im-adithya opened this issue 4 years ago • 3 comments

Fixes #3675

Description

Renamed the following:

themedStyled => styledThemed themedWithStyle => withStyleThemed themedUseStyletron => useStyletronThemed createThemedUseStyletron => createUseStyletronThemed createThemedStyled => createStyledThemed createThemedWithStyle => createWithStyleThemed

Scope

Minor: Linting

im-adithya avatar Sep 16 '21 17:09 im-adithya

@im-adithya is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 16 '21 17:09 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit eb1c81ebc906aa27964b0b54262e044514050213:

Sandbox Source
Basic usage Configuration

codesandbox-ci[bot] avatar Sep 16 '21 17:09 codesandbox-ci[bot]

@chasestarr made few changes regarding maintaining exports, please check.

I also would expect some flow type definition changes in some types.js files. Can you please try running yarn flow locally?

I did but didn't get any error regarding types.js files, is there any issue with it?

im-adithya avatar Sep 24 '21 19:09 im-adithya

Thank you for contributing this PR. I apologize, but landing this would require us to codemod a decent amount of internal code and we will not be prioritizing that effort.

chasestarr avatar Aug 16 '22 20:08 chasestarr