fix(textarea): add vertical resizing
Fixes #4054
Description
Changed resize: none to 'resize: vertical` so as to enable auto-sizing in textarea component
Scope
Patch: Bug Fix
@im-adithya is attempting to deploy a commit to the Uber UI Platform Team on Vercel.
A member of the Team first needs to authorize it.
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/HwihsXqCQrUxdkLqZ3t1etbiKmP3
✅ Preview: https://baseweb-git-fork-im-adithya-task-autosi-6fa2c1-uber-ui-platform.vercel.app
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/im-adithya/baseweb/pull/2
Ideally, we don't want this behavior on our default component so this change should be behind a resize prop and it's probably best to implement min/max rows with this change as well.
Sure! I'll change this to a prop then!
But how do we set max rows for a textarea component? (or is it max-height that you are referring to indirectly?)
Because the existing rows prop would kinda set the minimum rows (which is subject to resize unless min-height and max-height are set...)
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 17d22b505a6fcaf5ed3a6d9b51e8ddbd649aac7a:
| Sandbox | Source |
|---|---|
| Basic usage | Configuration |

Done @williamernest! Please review :)
Thank you for putting up this diff. We've added this feature here https://github.com/uber/baseweb/pull/5103