baseweb icon indicating copy to clipboard operation
baseweb copied to clipboard

fix(textarea): add vertical resizing

Open im-adithya opened this issue 4 years ago • 7 comments

Fixes #4054

Description

Changed resize: none to 'resize: vertical` so as to enable auto-sizing in textarea component

Scope

Patch: Bug Fix

im-adithya avatar Sep 10 '21 19:09 im-adithya

@im-adithya is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 10 '21 19:09 vercel[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/HwihsXqCQrUxdkLqZ3t1etbiKmP3
✅ Preview: https://baseweb-git-fork-im-adithya-task-autosi-6fa2c1-uber-ui-platform.vercel.app

vercel[bot] avatar Sep 10 '21 19:09 vercel[bot]

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: https://github.com/im-adithya/baseweb/pull/2

UberOpenSourceBot avatar Sep 10 '21 19:09 UberOpenSourceBot

Ideally, we don't want this behavior on our default component so this change should be behind a resize prop and it's probably best to implement min/max rows with this change as well.

williamernest avatar Sep 15 '21 00:09 williamernest

Sure! I'll change this to a prop then! But how do we set max rows for a textarea component? (or is it max-height that you are referring to indirectly?) Because the existing rows prop would kinda set the minimum rows (which is subject to resize unless min-height and max-height are set...)

im-adithya avatar Sep 15 '21 17:09 im-adithya

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17d22b505a6fcaf5ed3a6d9b51e8ddbd649aac7a:

Sandbox Source
Basic usage Configuration

codesandbox-ci[bot] avatar Sep 15 '21 19:09 codesandbox-ci[bot]

Screenshot from 2021-09-16 01-29-57

Done @williamernest! Please review :)

im-adithya avatar Sep 15 '21 20:09 im-adithya

Thank you for putting up this diff. We've added this feature here https://github.com/uber/baseweb/pull/5103

chasestarr avatar Aug 16 '22 20:08 chasestarr