RemoteShuffleService icon indicating copy to clipboard operation
RemoteShuffleService copied to clipboard
verified publisher icon uber

Add curly braces to the if statement to pass checkstyle, although it's not necessary.

Open merrily01 opened this issue 5 years ago • 4 comments

What changes were proposed in this pull request?

  1. Add curly braces to the if statement to pass checkstyle, although it's not necessary.

  2. Add space after token if.

PS：This PR can be cherry-picked to spark30 branch.

Why are the changes needed?

In order to modify the code specification and pass the checkstyle.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Test is not needed.

merrily01 avatar Dec 08 '20 08:12 merrily01

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 08 '20 08:12 CLAassistant

@hiboyang @mabansal @vectorijk Can one of the admins verify this patch?

Please confirm whether it is necessary to merge, thx.

merrily01 avatar Dec 09 '20 02:12 merrily01

Build Failed. The log is as follows: image It doesn't look like a problem with the project? @vectorijk

BTW: How to trigger rebuild by using Travis Ci ?

merrily01 avatar Dec 15 '20 06:12 merrily01

Hi~ @vectorijk @mabansal @hiboyang

Sorry to bother you，I found that the reason for Travis CI failure is that the external pull request cannot use the environment variable $ export FOSSA_API_KEY=[secure], see here.

So I wonder:

  1. How to deal with this situation?

  2. Does this project accept the PR from external contributors？

merrily01 avatar Jan 06 '21 12:01 merrily01