guide icon indicating copy to clipboard operation
guide copied to clipboard

refactor: change golint to revive

Open EpicStep opened this issue 4 years ago • 2 comments

golangci-lint recommend change golint to revive

EpicStep avatar May 15 '21 15:05 EpicStep

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 15 '21 15:05 CLAassistant

Similar comment to #124:

We haven't evaluated revive internally yet (to my knowledge, anyway), though we're aware of it and on paper it does look promising.

We don't recommend things that we don't do/use ourselves, so I'd prefer to wait on mentioning/recommending revive until we've had a chance to look into/adopt it internally first. I'll start a conversation internally about this, and we can leave the PR open in the meantime. (Note that whenever we do make this change, it should also include #124.)

mway avatar May 16 '21 13:05 mway