uap-core icon indicating copy to clipboard operation
uap-core copied to clipboard

iOS 13 UA agents - No major version

Open nitayk opened this issue 4 years ago • 3 comments

Hello, For some UAs it seems it fails to get the major OS version. example: parser.parse("braintest/0.4 CFNetwork/1098.7 Darwin/19.0.0") // res06:Client(UserAgent("braintest", Some("0"), Some("4"), None), OS("iOS", None, None, None, None), Device("iOS-Device", Some("Apple"), Some("iOS-Device")))

All rules assume iOS 13 UA should be CFNetwork/11.{0,100}, so CFNetwork/1098.7 can not be matched. adding additional rule like 'CFNetwork/1[01].{0,100} Darwin/(19).\d+' for iOS 13 might solve it

nitayk avatar Mar 07 '21 16:03 nitayk

@nitayk Can you please create a PR?

commenthol avatar Mar 08 '21 07:03 commenthol

Done :)

nitayk avatar Mar 08 '21 14:03 nitayk

That last PR is a mistake - shouldn't be related to this issue (it's for issue #500 )

nitayk avatar Mar 09 '21 07:03 nitayk