uSockets icon indicating copy to clipboard operation
uSockets copied to clipboard

Debug stuff left in

Open partyblob opened this issue 1 year ago • 2 comments

https://github.com/uNetworking/uSockets/blame/182b7e4fe7211f98682772be3df89c71dc4884fa/src/crypto/openssl.c#L539

Also whenever this part runs the server I am hosting becomes unreachable

partyblob avatar Dec 29 '24 01:12 partyblob

Can you run it under addresssanitizer or remove that printf? Maybe the string passed is not 0-terminated

uNetworkingAB avatar Dec 29 '24 03:12 uNetworkingAB

I am running this under uWebSockets.js, the string appears to be properly null-terminated, no crash or undefined behaviour occurs. After some looking it seems to be called by a .removeServerName()/.addServerName() pair. I can't tell if the cert file is being read properly as it's read by uSockets, but it's possible that if it failed to read or read the wrong value then SSL would fail, causing the server to become unreachable

partyblob avatar Dec 29 '24 10:12 partyblob