CodeAssist icon indicating copy to clipboard operation
CodeAssist copied to clipboard

Git Module

Open PriNova opened this issue 4 years ago • 6 comments

This is the integration of the JGit module.

It has a own folder in the codebase.

PriNova avatar Mar 26 '22 14:03 PriNova

Thank you for your suggestions and review. I will have a look about this issue and will commit changes asap

PriNova avatar Mar 26 '22 22:03 PriNova

I fixed the leak with the help of LeakCanary 2.8.1 and it gave no leaks anymore.

I chose lambdas in kotlin to avoid interfaces and to avoid extra object overhead .

If, in the future, the git module need more communication with other modules, then switching to the event API will be more powerfull, despite using kotlin solves alot what java lags.

PriNova avatar Mar 27 '22 14:03 PriNova

BTW: For events, you can use Kotlinx coroutines BroadcastChannel's & Flow's and make them LiveCycle-& LiveData aware with a viewModelScope as a coroutinecontext. So an Event API would be obsolete.

PriNova avatar Mar 27 '22 18:03 PriNova

Integrated ViewModel for configuration change. Added Snackbar to notify user-actions And refactored other logic into module

PriNova avatar Apr 05 '22 10:04 PriNova

Thank you for approving this PR @Kryslynn23 .

There were so many changes in nearly 1 year since opening the PR, that there are a lot breaking changes which needs to be resolved first.

I will have a look, if I can manage the time to resolve it and update this PR to the upstream. Suggestions?

PriNova avatar Feb 27 '23 00:02 PriNova

I close this PR because the project seems not to be maintained anymore.

PriNova avatar May 14 '24 20:05 PriNova