typetools
Integrate Optional Checker with Non-Empty Checker
I would prefer that users not run a checker named "RevisedOptionalChecker". I think that is your plan as well.
That’s exactly right.
I'm OK with doing the renaming in a separate PR.
Great, thanks!
On Jul 7, 2024, at 4:46 PM, Michael Ernst @.***> wrote:
@mernst commented on this pull request.
In checker/src/main/java/org/checkerframework/checker/optional/RevisedOptionalChecker.java https://github.com/typetools/checker-framework/pull/6685#discussion_r1667762041:
@@ -0,0 +1,21 @@ +package org.checkerframework.checker.optional;
+import java.util.ArrayList; +import java.util.Collection; +import org.checkerframework.checker.nonempty.NonEmptyChecker; +import org.checkerframework.framework.source.AggregateChecker; +import org.checkerframework.framework.source.SourceChecker; + +/** A version of the Optional Checker that runs the NonEmptyChecker as a subchecker. */ I would prefer that users not run a checker named "RevisedOptionalChecker". I think that is your plan as well.
I'm OK with doing the renaming in a separate PR.
— Reply to this email directly, view it on GitHub https://github.com/typetools/checker-framework/pull/6685#discussion_r1667762041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZ3EEESAFHTNI2JZ4HWYTDZLGSLPAVCNFSM6AAAAABJ64WBH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRRHEZDCMRQGM. You are receiving this because you were assigned.
@jyoo980 CI is passing. Is this ready for review? I ask because it is assigned to you (in the GitHub PR sense).
Yes, I’d appreciate a review so we can merge this in - thanks!
On Oct 4, 2024, at 1:36 PM, Michael Ernst @.***> wrote:
@jyoo980 https://github.com/jyoo980 CI is passing. Is this ready for review? I ask because it is assigned to you (in the GitHub PR sense).
— Reply to this email directly, view it on GitHub https://github.com/typetools/checker-framework/pull/6685#issuecomment-2394530174, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFZ3EECZSWEJVVCT2VHW74TZZ336JAVCNFSM6AAAAABJ64WBH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUGUZTAMJXGQ. You are receiving this because you were mentioned.