algebra icon indicating copy to clipboard operation
algebra copied to clipboard

Why don't we move Spire's Module/VectorSpace/MetricSpace/etc. here?

Open ctongfei opened this issue 8 years ago • 3 comments

I think that these typeclasses should go into Algebra.

ctongfei avatar May 12 '17 16:05 ctongfei

I think we could do this. Would you be interested in opening a PR starting at the bottom of that hierarchy?

johnynek avatar May 13 '17 03:05 johnynek

Thanks :-) I'd be happy to do that.

ctongfei avatar May 13 '17 04:05 ctongfei

@ctongfei Beware!

I'm currently revising the Spire test suite. The Spire hierarchy has a few inconsistencies; for example, Module pretends to be noncommutative, but actually it is defined in a way that only makes sense for commutative rings. MetricSpace/InnerProductSpace/CoordinateSpace are only valid when the vector spaces are defined on the reals, ...

denisrosset avatar Nov 14 '17 18:11 denisrosset