eta-hackage icon indicating copy to clipboard operation
eta-hackage copied to clipboard

Patch directory-1.3.1.1

Open rpeszek opened this issue 8 years ago • 6 comments

This is related to https://github.com/typelead/eta-hackage/issues/42 since directory-1.3.1.1 tries to install unix-2.7.2.2 and that fails.

OS-X Sierra I am at current head commit on eta master

Ankh-Morpork:eta rpeszek$ git rev-parse HEAD
1dbe87b19f815ba12ec33f558cb7b572a74e03c1

the log:

Resolving dependencies...
Configuring unix-2.7.2.2...
Building unix-2.7.2.2...
Failed to install unix-2.7.2.2
...

rpeszek avatar Sep 03 '17 19:09 rpeszek

This is a test project that will fail with etlas install --dependencies-only It has directory as the only package dependency.

https://github.com/rpeszek/eta-hackage-build-test/tree/eta-hackage-issue-53

rpeszek avatar Sep 03 '17 20:09 rpeszek

The fix could be as simple as correcting directory >= 1.3.0.0 && <= 1.3.10 to directory >= 1.3.0.0 && <= 1.3.1.0 see the readme file

rpeszek avatar Sep 03 '17 20:09 rpeszek

Can you send a PR to fix the README? You're also welcome to apply the older version patch onto the new version and see if that fixes the build for the latest version.

rahulmutt avatar Sep 03 '17 21:09 rahulmutt

@rahulmutt I will do (tomorrow), I noticed the package version issue after I created this ticket.

rpeszek avatar Sep 03 '17 22:09 rpeszek

I see the readme patch is done and readme is now fixed.
Precursory look tells me that the patching the newest 1.3.1.1 will likely be a bit of work as there were quite a few changes around previously patched code.
Note 1.3.1.1 version existed at the time of https://github.com/typelead/eta-hackage/pull/41 so probably patching it will need to be different.

Please feel free to close this ticket. I may have a go at 1.3.1.1 some time in the future if it remains not patched.

rpeszek avatar Sep 04 '17 18:09 rpeszek

I'll leave this ticket open to track the patching of directory-1.3.1.1.

rahulmutt avatar Sep 04 '17 18:09 rahulmutt