minimal-twitter icon indicating copy to clipboard operation
minimal-twitter copied to clipboard

Removing top bar and Tweet button on a mobile/responsive display is not functional due to divergent selectors

Open MakotoTheKnight opened this issue 2 years ago • 0 comments

I'm interested in leveraging this plugin on a mobile device, and I'm running into an issue in which the tweet button and the top nav bar layers are still visible if I am running on mobile.

Browser: Firefox Mobile (version 112.0a nightly); using the workaround to install this plugin on the device via Debug Options

I'm able to reproduce this behavior in a responsive browser display (max 499-ish px width) as well.

What's needed in the selectors.js file is the ability to select the navigation on mobile and the tweet button on mobile, and I can provide these here.

# Mobile Top Banner
[data-testid="TopNavBar"] > div > div:nth-of-type(2) > nav:only-child[role="navigation"]
# Mobile Tweet button
#layers > div > div > div > aside[role="complementary"] > div > [data-testid="FloatingActionButtons_Tweet_Button"]

The tweet button may not require that much selection since it's really data-testid="FloatingActionButtons_Tweet_Button"] that drives it, but it depends on if you want to also remove the aside that controls it.

Note: While I can still see labels if I expand the view port on mobile, I don't consider that an issue here since they're still hidden as long as I don't interact with them, and finding a way to select them is pretty painful since they have no attributes that identify them. I may look for a way to solve that problem in the near future, though. So, I do not wish for that to be captured in this bug report.

MakotoTheKnight avatar Feb 26 '23 16:02 MakotoTheKnight