ControlRoom icon indicating copy to clipboard operation
ControlRoom copied to clipboard

feat: Xcode 15 localization

Open Harry-KNIGHT opened this issue 2 years ago • 2 comments

Use Xcode 15 localization for have all localized into one file and translate this big open source project to a larger audience of developers

Harry-KNIGHT avatar Nov 30 '23 21:11 Harry-KNIGHT

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

twostraws avatar Dec 06 '23 10:12 twostraws

Hello! Thank you for this – it's an important step forward. Before I merge, I just want to check why we're using NSLocalizedString. As this project is written almost entirely in SwiftUI, I'm rather hopeful we get automatic localization through the framework.

@twostraws be careful, do not merge at this MR step, I opened it as draft for you can see my proposal, if this way of doing it is okay for you I will make it for all text and localized already existing.

If you have any advices I'll take them

Harry-KNIGHT avatar Dec 11 '23 06:12 Harry-KNIGHT