Cook icon indicating copy to clipboard operation
Cook copied to clipboard

docker force-pull-image ignored

Open mneagul opened this issue 7 years ago • 2 comments

The docker force-pull-image option seems to be ignored. Is this expected behaviour ?

An example job is:

{
	"jobs": [{

		"disable-mea-culpa-retries": true,
		"mem": 1000,
		"application": {
			"name": "teo21",
			"version": "1.0.0"
		},
		"name": "teo21",
		"command": "/somepath/ewps-wrapper --job-info http://someserver/result/.../job_info.json",
		"max_runtime": 86400000,
		"max-retries": 10,
		"uuid": "163719da8-394f-44f9-9e6d-8a17500d5459",
		"executor": "cook",
		"container": {
			"type": "DOCKER",
			"docker": {
				"image": "our-registry:5000/ewps9",
				"network": "BRIDGE",
				"force-pull-image": true

			},
               "volumes": [
		          {
		            "container-path": "/etc/hosts",
		            "host-path": "/etc/hosts"
		          }
        ]

		},
		"cpus": 1
	}]

}

mneagul avatar Feb 17 '18 19:02 mneagul

I think another Cook user identified this as a problem with the Mesomatic library we're using in Cook. See clojusc/mesomatic#40 for his patch. If you upgrade the version of Mesomatic used by Cook to [clojusc/mesomatic "1.0.1-r1"] I think it should work correctly.

DaoWen avatar Feb 19 '18 04:02 DaoWen

We should update our mesomatic dependency and add an integration test for this.

DaoWen avatar Mar 31 '18 16:03 DaoWen