Tobias Wollgam
Tobias Wollgam
I opened the PR #717 that contains git hooks. They check if spaces are used instead tabs and if there is whitespace at end of a line. Server-side hooks can't...
If this PR is merged I will update the style guide in the wiki how to install the git hooks and what they do.
@Baklap4 I agree what belongs the server side. Not to offer server-side hooks may be a decision for security reasons but it denies solutions which could reject commits. If we...
> Hmm after installing the hooks (with option 'all' defined) i saw it didn't work with other text based files due to the extension constraint. Please add the following to...
This one suggested by @Tronic > logger.info("songs", "Loaded", m_songs.size(), "songs") would enable this too (btw it is c++20) > logger.info("songs", std::format("Loaded {} songs", m_songs.size())) or with an user defined literal...
I think it is a good idea to have a look at those package formats and to evaluate if they could be supported. But this would not be the top...
Yes you are right with the screen after singing, but the problem is that one can not reach it from main screen. And the workflow is reverted. I want to...
> So technically this issue should be solved with the other issue you added #572 I would like to keep the things separated, not making issues too big.
So, if I develop a "player configuration screen" I will take the existing player screen as "template". The data should come from and go to the Players class. There will...
@yoda-jm is it OK if I take this PR. If I can I would try to update it and finally to merge it.