the-algorithm optimized approxEquals in GeoObject.java

To make the code more concise and efficient, we can simplify the conditional expressions and combine multiple conditions into a single return statement using short-circuit evaluation.

Apr 01 '23 17:04 ttomczak3

All committers have signed the CLA.

Apr 01 '23 17:04 CLAassistant

Best pull request so far. Appreciate the effort.

Apr 01 '23 17:04 RickHPotter

LGTM

Apr 01 '23 17:04 hungtruong

genius

Apr 01 '23 18:04 Quinn-Barber

Impossible; an actual PR?

On this repo?

Apr 01 '23 18:04 preland

Groundbreaking. This could be the missing link.

Apr 01 '23 18:04 0o120

LGTM

Apr 01 '23 19:04 Claaas

LGTM

Apr 01 '23 21:04 Conradyen

better-algorithm

Apr 02 '23 01:04 peiwenxu

Groundbreaking

Apr 02 '23 13:04 hexaquarks

Feature is a little too big for the scope of this project; perhaps create a fork?

Apr 02 '23 21:04 numberisnan

this would be the least lines and most maintainable.

return a!=null&&b!=null&&a.accuracy==b.accuracy&&Math.abs(a.latitude-b.latitude)<=COORDS_EQUALITY_THRESHOLD&&Math.abs(a.longitude-b.longitude)<=COORDS_EQUALITY_THRESHOLD&&a.radius==b.radius&&a.source==b.source;

Apr 05 '23 21:04 davidawad

this would be the least lines and most maintainable.

return a!=null&&b!=null&&a.accuracy==b.accuracy&&Math.abs(a.latitude-b.latitude)<=COORDS_EQUALITY_THRESHOLD&&Math.abs(a.longitude-b.longitude)<=COORDS_EQUALITY_THRESHOLD&&a.radius==b.radius&&a.source==b.source;

I noticed that the Double.compare() method was removed. Can you explain the reason for this? It seems to be a more accurate way to compare two double values.

Apr 05 '23 22:04 ttomczak3

this would be the least lines and most maintainable.
return a!=null&&b!=null&&a.accuracy==b.accuracy&&Math.abs(a.latitude-b.latitude)<=COORDS_EQUALITY_THRESHOLD&&Math.abs(a.longitude-b.longitude)<=COORDS_EQUALITY_THRESHOLD&&a.radius==b.radius&&a.source==b.source;
I noticed that the Double.compare() method was removed. Can you explain the reason for this? It seems to be a more accurate way to compare two double values.

I would stick with the compare() method. Double values can have rounding inaccuracies due to their representation in the computer's limited memory space of (usually) 64 bits.

https://www.baeldung.com/java-comparing-doubles

Apr 06 '23 00:04 shailrshah

this would be the least lines and most maintainable.

return a!=null&&b!=null&&a.accuracy==b.accuracy&&Math.abs(a.latitude-b.latitude)<=COORDS_EQUALITY_THRESHOLD&&Math.abs(a.longitude-b.longitude)<=COORDS_EQUALITY_THRESHOLD&&a.radius==b.radius&&a.source==b.source;

I noticed that the Double.compare() method was removed. Can you explain the reason for this? It seems to be a more accurate way to compare two double values.

I would stick with the compare() method. Double values can have rounding inaccuracies due to their representation in the computer's limited memory space of (usually) 64 bits.

https://www.baeldung.com/java-comparing-doubles

Exactly!

Apr 06 '23 02:04 ttomczak3