summingbird icon indicating copy to clipboard operation
summingbird copied to clipboard

Make mergeBatched protected instead of private.

Open non opened this issue 7 years ago • 3 comments

There are reasons why particular implementations might want to override this method (for example, to support custom serialization strategies), so let's make it protected instead of private.

non avatar Apr 09 '18 22:04 non

👍

Thanks!

merge when green.

johnynek avatar Apr 09 '18 22:04 johnynek

looks like this fails mima, naturally...

So we can make the change at the next mima break, maybe when we release for scalding 0.18

johnynek avatar Apr 09 '18 23:04 johnynek

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '19 23:11 CLAassistant