scrooge

scrooge copied to clipboard

Generate traits decoupled from Thrift dependencies

3

Currently, the generated code is strongly coupled to Thrift. This locks the whole codebase into Thrift, or forces developers to manually duplicate types and convert between them. Instead, the generated...

yawaramin

build(deps-dev): bump commons-io from 2.4 to 2.7 in /scrooge-maven-plugin

1

Bumps commons-io from 2.4 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands...

dependabot[bot]

Add option to generate higher-kinded-type service interface

2

**Is your feature request related to a problem? Please describe.** [A recent release](https://github.com/twitter/scrooge/commit/8d768ca620a33d18b89492a7a2077007cedb6e7d) has removed the higher-kinded-type (HKT) interface when generating services (i.e. it removed the option to write `Service.MethodPerEndpoint`...

henryxparker

Unused imports included in headers break build

5

Unused imports are included in the headers of generated files causing 2.12 builds with the default -Yfatal-warnings` setting to fail (unless the correct linting options are unset) ### Expected behavior...

chrisbenincasa

Add configuration choice of getting an immutable type in code generation for `bytes` thrift type

1

Thrift type `bytes` currently gets generated as a `java.nio.ByteBuffer`. This type is mutable and if not careful defensive copying is used reading it changes it's internal position in the array....

rogern

Unavoidable "[Importer$] Expected to find just 1 match" warnings in sbt sub-project builds

6

**Describe the bug** For an sbt [multi-project](https://www.scala-sbt.org/1.x/docs/Multi-Project.html) build which uses the ScroogeSBT autoplugin on a _subproject_, an unavoidable warning message (`warn [Importer$] Expected to find just 1 match for ...`,...

rtyley

Feature Suggestion: Custom type adapters

1

When using the service defintion of the generated code, there is a mismatch between the high level types and the underlying thrift binary serialization strategy. The canonical example for Scala/Java...

tnn

Using irrefutable extractors for Scala structs

9

## Problem Up until [Scala 2.13.4](https://github.com/scala/scala/pull/9140), having custom extractors in a pattern match disables exhaustivity checks by the compiler. This is true, unless the extractor is "irrefutable", which means that...

ncreep

Interested in adding support for typescript?

3

Hi everyone, The Guardian has developed a Typescript extension to the scrooge compiler, would you be interested in merging it upstream? I can see the scrooge compiler already support a...

alexduf

`com.twitter.scrooge.ast.Field.default` is not callable from Java because it conflicts with a java keyword. ### Expected behavior The `Field` class has a Java friendly method-adapter called `default_` or `getDefault` ...

heldev