scalding icon indicating copy to clipboard operation
scalding copied to clipboard

Scala implicit ordering fun -- have 2 forms of sketch, defaulting to …

Open ianoc opened this issue 9 years ago • 5 comments

…the existing

@johnynek as we were discussing for the sketch method. More of a consideration than hard PR

ianoc avatar Mar 05 '16 00:03 ianoc

looks good to me modulo the naming (I would use names for classes more specific to SketchJoin)

johnynek avatar Mar 05 '16 01:03 johnynek

:+1: I like this. You can use the OrderedSerialization macros, not have an implicit conversion in scope and do a more efficient join at the same time. Seems like a win.

johnynek avatar Mar 06 '16 02:03 johnynek

what do you think of this @rubanm @isnotinvain ? I like not having to set up an implicit conversion and the ability to use compiler generated serializers.

johnynek avatar Mar 12 '16 01:03 johnynek

@johnynek @ianoc Sorry late to this. Just one unit test comment. LGTM!

rubanm avatar Mar 29 '16 16:03 rubanm

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant