hraven icon indicating copy to clipboard operation
hraven copied to clipboard

Upgrade jackson and jersey

Open shrijeet opened this issue 11 years ago • 5 comments

The patch upgrades jackson to 2.x and jersey 1.8.x. Jackson 2.x has moved to new namespace, the changes in java files are mostly fixing imports based on new name space. Additionally CustomDeserializerFactory has been removed, the new approach uses Module for adding custom deserializers.

shrijeet avatar Jun 27 '14 01:06 shrijeet

Hi @shrijeet Thanks for sending in a pull request, looking through it. Just wanted to understand if there is any issue that you were facing with current jackson, jersey versions in hRaven and hence the pull request to upgrade.

thanks Vrushali

vrushalic avatar Jun 27 '14 01:06 vrushalic

I @vrushalic, I explained the reasoning on user list. Pasting same message here:

"We are planning to use our own rest server implementation which is based on dropwizard. But want to avoid rewriting the existing Java beans which are serialized into JSON. In order to do so, we would prefer hraven-core & custom rest service use same version of Jackson. The rest library uses Jackson 2.x, hence this pull request.

I realize this may not be compelling enough reason for hraven-core to upgrade its dependency, but I am hoping this is perceived as harmless change & gets accepted. Unit tests have passed & I am running end to end test at the time of writing this message. "

shrijeet avatar Jun 27 '14 01:06 shrijeet

We ran end to end test (ran ETL on hadoop 1.x logs and served the JSON result from the hraven-core's rest server) & found no issues after upgrade.

shrijeet avatar Jun 27 '14 19:06 shrijeet

In principle this is fine with me. We need to pull in the change and make sure that this does not break anything with our setup on our last remaining Hadoop 1 clusters and our Hadoop 2 clusters.

jrottinghuis avatar Jul 01 '14 04:07 jrottinghuis

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant