finagle icon indicating copy to clipboard operation
finagle copied to clipboard
verified publisher icon twitter

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

Open codefromthecrypt opened this issue 9 years ago • 6 comments

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

codefromthecrypt avatar Jul 13 '16 04:07 codefromthecrypt

@adriancole @mosesn If no one is working on it, i would like to work on this issue.

cryptoque avatar Mar 19 '18 17:03 cryptoque

please do!

codefromthecrypt avatar Mar 20 '18 00:03 codefromthecrypt

@cryptoque 👍

mosesn avatar Mar 29 '18 18:03 mosesn

@mosesn Are you still working on this? If not, I'd like to give it a try

flostadler avatar Aug 05 '19 08:08 flostadler

@flostadler it doesn't appear that anyone has been working on this. Please do give it a try.

kevinoliver avatar Aug 05 '19 22:08 kevinoliver

@kevinoliver All right, I'm on it!

flostadler avatar Aug 06 '19 06:08 flostadler