Update this to use a golang vendor directory and use the docker plugin helper package
Hi, I do not see much merging of PRs so just want to check to see if this is likely to be merged, I would like to use this plugin for some CI systems.
I would like to make the following updates
- use golang vendor directory - using latest version of godep
- update to use latest package versions - assuming all tests pass
- update to use the authorization plugin helper package (https://github.com/docker/go-plugins-helpers/tree/master/authorization)
Will need to this anyway, just want to get an indication if a PR would be accepted, I don't plan to change how the plugin works, as looks perfect for my needs, so those changes would be minimal
Thanks Pat
Hi @pmcgrath, we will appreciate a PR re vendor package and package updates. Re plugin-helper library, this is essentially a very limited version of what this plugin does, so I'm not sure what is the added benefit, can you please explain your motivation.
@liron-l re using the helper package, my thinking was that we would follow the docker docs convention, as you said it doesn't buy us anything, would possibly need to alter so we could both support the authorizer and auditor.
I'm happy to just to take care of the following
- vendoring
- Altering the makefile to address foreach not working in bash
- Updating the order of import statements based on gofmt
- Fixing some url's and readme content