vertex icon indicating copy to clipboard operation
vertex copied to clipboard

"Virtual" connection identifier should be a UUID4, not an integer counter

Open glyph opened this issue 9 years ago • 4 comments

glyph did not know things about cryptographic security when he wrote this

glyph avatar Dec 20 '16 02:12 glyph

The relevant AMP command is in vertex.command.Virtual

glyph avatar Dec 20 '16 02:12 glyph

Choke and Unchoke both refer to the same kind of connection ID

glyph avatar Dec 20 '16 02:12 glyph

There's also a couple of callRemoteString invocations which imply AMP commands on vertex.q2q.VirtualTransport and the amp_WRITE and amp_CLOSE methods on Q2Q.

glyph avatar Dec 20 '16 02:12 glyph

This might not actually be necessary. The comment about cryptographic security above was somewhat misguided, since the identifiers are scoped to the (authenticated) connection.

glyph avatar Jan 02 '17 09:01 glyph