flex-plugin-builder icon indicating copy to clipboard operation
flex-plugin-builder copied to clipboard
verified publisher icon twilio

react-test-renderer resolves to 16.14.x which causes issues target highest flex version

Open shelbyz-prft opened this issue 4 years ago • 1 comments

https://github.com/twilio/flex-plugin-builder/blob/635c2dbbf3e9e51e5f6e967a5a089f63c9e04e4a/packages/flex-plugin-scripts/package.json#L47

The latest version supported within Flex is 16.13.1 and if we allow '^' targeting of version for react/react-dom we can get versions later than are what is supported within Flex. Where this runs into additional problems is an automated deployment system would be unable to answer a confirm/prompt found in flex-plugin-scripts to accept deploying a plugin targeting a later version of react due to "^".

https://github.com/twilio/flex-plugin-builder/blob/13080e2d8140ee5e874f699e51814dc99e0bfd42/packages/flex-plugin-scripts/src/scripts/deploy.ts#L75-L93

If we changed react-test-render to lock versions this would allow plugin developers to also lock the react version without issue.

shelbyz-prft avatar Apr 06 '21 20:04 shelbyz-prft

@shelbyz-prft are you suggesting that we replace "react-test-renderer": "^16.13.1" with "react-test-renderer": "16.13.1"?

ktalebian avatar May 05 '21 17:05 ktalebian

Hi,

This is a long open item more than a year now, hence closing it. Feel free to reopen it if still required.

anjha91 avatar Oct 04 '23 08:10 anjha91