twenty icon indicating copy to clipboard operation
twenty copied to clipboard
Published 3 months ago • verified publisher icon twentyhq

Modals with DropdownMenuItems doesn't close in one click

Open harshit078 opened this issue 1 year ago • 2 comments

Bug Description

  • Modals like Address, ARR, Currency or any other custom field requires 2 clicks to close the modal.
  • Page overflow in mobile viewports

Current Behaviour

https://github.com/user-attachments/assets/5161ccdb-affc-4893-b9e6-dbb8019ee416

https://github.com/user-attachments/assets/e55ccde1-de57-4543-9bf0-0ae4212c670b

Expected behavior

  • Modals with dropdownInput should close in oneclick
  • Overflow shouldn't occur for mobile viewports

harshit078 avatar Dec 17 '24 12:12 harshit078

Viewport HAVE to be detected upon scriptload or risk losing compatibility (source).

As of me, if I were person who decides here, I'd rather loose compatibility, but thats me.

MrSuddenJoy avatar Dec 17 '24 14:12 MrSuddenJoy

Can i work on this issue?

Lucifer4255 avatar Dec 17 '24 14:12 Lucifer4255

@Bonapara @lucasbordeau this is not a bug to me, from an eng perspective at least this is an healthy trade off. happy to discuss it further

charlesBochet avatar Jan 13 '25 09:01 charlesBochet

I agree with @charlesBochet; the double-click is the desired behavior.

Bonapara avatar Jan 13 '25 10:01 Bonapara