bootstrap icon indicating copy to clipboard operation
bootstrap copied to clipboard

Add cursor-pointer rule for search clear

Open DenisLopatin opened this issue 2 years ago • 10 comments

Prerequisites

Proposal

Pseudo-element with id search-clear does not have cursor-pointer, why? How about adding this css rule? It seems right to me.

2023-08-26_17-56-09

2023-08-26_18-00-32

v5.3.1

Motivation and context

This is a standard way of feedback for users, a trifle, but nevertheless

DenisLopatin avatar Aug 26 '23 15:08 DenisLopatin

@DenisLopatin Yess there should be a pointer on the cancel button. Can I work on this issue?

dhruvchandak30 avatar Sep 01 '23 07:09 dhruvchandak30

yes, of course @dhruvchandak30

DenisLopatin avatar Sep 01 '23 07:09 DenisLopatin

@DenisLopatin Can you please mention where is this Search Bar located on website?

dhruvchandak30 avatar Sep 02 '23 12:09 dhruvchandak30

@dhruvchandak30 https://getbootstrap.com/docs/5.3/components/navbar/#supported-content for example

DenisLopatin avatar Sep 02 '23 13:09 DenisLopatin

@DenisLopatin Can you please mention the location of where did you find this code (in which directory)?

image

Because I am not able to see the code while inspecting the element.

image

dhruvchandak30 avatar Sep 04 '23 05:09 dhruvchandak30

@dhruvchandak30 This is part of the shadow DOM. It is not so easy to reach it. You can do the following to commit the changes:

2023-09-04_20-37-57

2023-09-04_20-52-55

DenisLopatin avatar Sep 04 '23 17:09 DenisLopatin

I reassembled the project and made sure it worked. If the bootstrap.css team approves, then congratulations))

DenisLopatin avatar Sep 04 '23 17:09 DenisLopatin

@julien-deramond Now should I change the commit message from CSS: Cursor Pointer rule for cancel button to CSS: Added Cursor Pointer for search clear button. ?

dhruvchandak30 avatar Sep 08 '23 10:09 dhruvchandak30

Don't worry @dhruvchandak30 we can change the commit messages when we merge PRs

julien-deramond avatar Sep 08 '23 10:09 julien-deramond

This is actual now? The PR was closed

DenisLopatin avatar Mar 05 '25 23:03 DenisLopatin