react-tippy icon indicating copy to clipboard operation
react-tippy copied to clipboard

Set and remove element aria-describedby base on popper

Open tuanthieu2993 opened this issue 7 years ago • 3 comments

Summary

To fix aria attribute do not have valid value, issue: https://github.com/tvkhoa/react-tippy/issues/89

As describedby need to point to a valid id, that means id that exists, while current implementation set it from beginning and keep it there even when the popper is hidden - removed from DOM.

This update will help solve issue as we only set it when show and remove when hide the popper

Screenshots

When page is init with tooltipped elements image

When popper is shown image

When popper is hidden image

tuanthieu2993 avatar Oct 02 '18 16:10 tuanthieu2993

Hi @tvkhoa, this fix was approved. Will this be merged and released soon? Thanks!

carlosparreno avatar May 22 '19 19:05 carlosparreno

bueller? This is breaking aXe tests and I'd like to re-enable them

kjchiu avatar Jun 25 '19 20:06 kjchiu

Hello guys, I recommend switching to https://github.com/atomiks/tippy.js-react It's the official package and it's totally a11y compliance!

EmaSuriano avatar Sep 19 '19 09:09 EmaSuriano