spring-batch-lightmin icon indicating copy to clipboard operation
spring-batch-lightmin copied to clipboard

removed spring allow-bean-definition overriding issue

Open sudoHackIn opened this issue 4 years ago • 1 comments

Hello, thanks for this very helpful project! We would like to use it in our system, but it's not possible to use bean overriding in our case. So i would like to contribute and hope, that with your help, we can remove this issue.

I removed default bean definitions from -core projects. Now configuration looks like spring auto-configurations(base module only defines main interfaces, specific implementations contains beans) For example to enable client discovery we should include client-discovery-core + client-discovery~ (where actually MetaDataExtender is configured)

Because of that, cluster - standalone -embeded configuration was restructured (not sure, that was correct strategy)

Embeded - is as BaseStandaloneConfiguration(without remote admin and job services) configuration with embeded admin and job services and map repositories (application and job execution event) Standalone configuration is a BaseStandaloneConfiguration with remote admin services and map repositories (application and job execution event) cluster-core is a BaseStandaloneConfiguration with cluster features And InfinispanServerClusterConfiguration is a cluster with Infinispan repostiories and other features.

I tried to save all presented configurations and module dependencies, with a few required changes, due to bean overriding. But it seems, that we should move to more distinct feature set with autoconfiguration for each of them (for example - base repository + jdbc / map

sudoHackIn avatar May 28 '21 10:05 sudoHackIn

Hi @sudoHackIn thank you for your contribution. I will take some time to verify the PR. I will come back to you as soon as possible.

tuxdevelop avatar May 28 '21 16:05 tuxdevelop