tus-node-server icon indicating copy to clipboard operation
tus-node-server copied to clipboard
verified publisher icon tus

@tus/server: allow onUploadFinish hook to override response data

Open netdown opened this issue 1 year ago • 1 comments

Follow-up on #606. Changes based on #599.

netdown avatar May 07 '24 12:05 netdown

🦋 Changeset detected

Latest commit: 38c3114c5ce3074280f7b4c0162894e483743ae7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tus/server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 07 '24 12:05 changeset-bot[bot]

Thank you for the test too! From there I understood that it's important to include the "res" object too so it works! Also that line "If the function returns the (modified) response, the upload will finish." in the README file is very important, but in the latest version is not present anymore. Could you put it back?

andreineamtu avatar Aug 20 '24 09:08 andreineamtu

So it wasn't clear that you have to return res in the object? In the next major it will be removed but for now it's needed.

Murderlon avatar Aug 20 '24 10:08 Murderlon