tus-node-server icon indicating copy to clipboard operation
tus-node-server copied to clipboard

Consider server and browsers with creation url

Open bhstahl opened this issue 9 years ago • 2 comments

Right now the creation extension omit's thee protocol from a created url, which can cause some issues using tus-js-client server side (https://github.com/tus/tus-java-client/issues/10#issuecomment-258384118). We should consider a new approach that works in the browser and server

bhstahl avatar Nov 17 '16 12:11 bhstahl

tusd will derive the protocol from the request (https://github.com/tus/tusd/blob/master/unrouted_handler.go#L633-L637). Later this value may be overwritten by the X-Forwarded-Proto header (https://github.com/tus/tusd/blob/master/unrouted_handler.go#L645-L647) which is commonly used by proxies. A similar approach may be useful tus-node-server.

Acconut avatar Dec 03 '16 18:12 Acconut

Like that option @Acconut, we'll follow suit

bhstahl avatar Dec 09 '16 12:12 bhstahl