tus-node-server icon indicating copy to clipboard operation
tus-node-server copied to clipboard
verified publisher icon tus

GSC Datastore: Add support for contentType property

Open tkrugg opened this issue 7 years ago • 2 comments

closes #57

This PR follows up on #57

image

I couldn't get test/Test-GCSDataStore.js so i'll trust the travis output to fix the tests

tkrugg avatar Aug 23 '18 05:08 tkrugg

I was going to write it but I couldn't get the GCS test suite to run locally. It does run on travis. I may be missing some env variables. Are there a few steps to follow before running them locally?

Yes, there are a few steps to follow. They are not directly documented anywhere but that's on my list to improve. The basic steps should be:

  • Create a bucket on GCS
  • Save the keyfile from Google Cloud as keyfile.json in the root of the tus-node-server directory
  • Adjust the project Id and bucket name values in test-GCSDataStore.js: https://github.com/tus/tus-node-server/blob/9ac6bf9e4964f86b93a36f765405ffc43f535c5e/test/Test-GCSDataStore.js#L17-L19
  • Upload the file test/test.mp4 as dont_delete_this_file.mp4 to your bucket

I think that should be all the steps. Let me know if they work for you.

Thank you very much for taking the time to review this PR. I appreciate.

You're welcome. Thank you very much for contribution.

Acconut avatar Sep 19 '18 08:09 Acconut

@tkrugg Were you able to have a look at the GCS-tests yet? Is this PR ready from your side?

Acconut avatar Oct 08 '18 11:10 Acconut

Closing this as stale and the source has now significantly diverged. Thanks for taking the time to contribute.

Murderlon avatar Dec 13 '22 13:12 Murderlon