python-ouraring icon indicating copy to clipboard operation
python-ouraring copied to clipboard

Fix /heartrate query parameters

Open hexponent opened this issue 1 year ago • 1 comments

/heartrate endpoint has slightly different query paramaters, so here I make adjustment for that

Also, if timestamp includes timezone info, which is separated by +, e.g. 2024-04-07T07:22:48+00:00, then in url it is considered as space, so we need to escape it. That's exactly what urlencode does. BTW it is the same function that requests use for escaping characters as well

hexponent avatar Apr 07 '24 09:04 hexponent

@turing-complet Please review. Also, it is the last PR for now, so please make a release after that

hexponent avatar Apr 07 '24 09:04 hexponent

Thanks, LGTM. I'll try to get a release out soon.

turing-complet avatar Apr 21 '24 19:04 turing-complet