sf2github icon indicating copy to clipboard operation
sf2github copied to clipboard

crash in handle_tracker_item - doesn't detect bad credentials.

Open simsong opened this issue 13 years ago • 1 comments

In this code:

            number = issue['number']
            print 'Attaching labels: %s' % labels
            rest_call('POST', 'issues/%s/labels' % (number), labels)
            for comment in comments:
                print 'Creating comment: %s' % comment[:50].replace('\n', ' ').replace(chr(13), '')
                rest_call('POST', 'issues/%s/comments' % (number), {'body': comment})
            if closed:
                print 'Closing...'
                rest_call('PATCH', 'issues/%s' % (number), {'state': 'closed'})

I'm having a crash because the dictionary issue does not have a field number. It has these values:

('no issue number: ', {u'message': u'Bad credentials'})

It should pick up Bad Credentials better?

simsong avatar Dec 07 '12 12:12 simsong

It should. Feel free to send me a pull request :)

ttencate avatar Dec 07 '12 23:12 ttencate