sf2github
sf2github copied to clipboard
crash in handle_tracker_item - doesn't detect bad credentials.
In this code:
number = issue['number']
print 'Attaching labels: %s' % labels
rest_call('POST', 'issues/%s/labels' % (number), labels)
for comment in comments:
print 'Creating comment: %s' % comment[:50].replace('\n', ' ').replace(chr(13), '')
rest_call('POST', 'issues/%s/comments' % (number), {'body': comment})
if closed:
print 'Closing...'
rest_call('PATCH', 'issues/%s' % (number), {'state': 'closed'})
I'm having a crash because the dictionary issue does not have a field number. It has these values:
('no issue number: ', {u'message': u'Bad credentials'})
It should pick up Bad Credentials better?
It should. Feel free to send me a pull request :)