PyPump icon indicating copy to clipboard operation
PyPump copied to clipboard

Put OFirehose example in documentation to show how to subclass Feed class

Open moggers87 opened this issue 11 years ago • 3 comments

We already have everything needed to read off OFirehose, but it would be nice to provide users with a something that they can just call and get Note objects etc. out of it.

moggers87 avatar Sep 27 '14 21:09 moggers87

I cant see the full conversation about this on pump.io, but i assume we're just talking about loading the https://ofirehose.com/feed.json file into a Feed object?

I added a p firehose (why are you giggling?) command with code that could easily be added to PyPump instead

kabniel avatar Sep 28 '14 11:09 kabniel

That's a lot simpler than I was imagining - maybe we could add something similar to the documentation? (ha!)

moggers87 avatar Sep 28 '14 18:09 moggers87

It's not a perfect solution as the ofirehose feed is more limited than the usual pump.io feeds and the class will have to be re-instantiated every time you want to get items from it, it could probably be improved by overriding a few more methods. For the p firehose command it's good enough though as we only use it once for every time the command is run.

kabniel avatar Sep 28 '14 19:09 kabniel