:export-session-to not keeping the configured :highlight (if set in the session)
lnav version v0.13.0-rc2
Describe the bug This is pretty much like #1352 , but for the ":highlight", if configured : the configured value is stored in the session (:save-session keeps it) but it is not exported (:export-session-to does not have it)
To Reproduce
- Open a log file
- Set a highlighting pattern (:highlight whatever)
- Save the session (:save-session)
- Export the session (:export-session-to filename)
Saved session has the highlight in there, but the exported session in text format does not.
Rationale may very well be exactly the same as in #1352 , and I am perfectly fine with it, and even if it is so much more relevant for session sharing to keep / drop the shown / hidden fields compared to just a highlight, it may be reasonable to provide the same compromise as in the mentioned #1352 for the highlight as well (so that it gets in the session export, but commented out).
While doing my testing I could confirm that the changes made for #1352 are as described in the issue and seem to work as planned, so probably you want to close that one out while at it.
Thanks a lot.